From f6f2e946aa4da1b378f44dbc79708b546f2a0c0e Mon Sep 17 00:00:00 2001 From: Xiangqian Zhang Date: Fri, 17 Jan 2025 17:46:03 +0800 Subject: [PATCH] net: mii: Fix the Speed display when the network cable is not connected Two different models of usb card, the drivers are r8152 and asix. If no network cable is connected, Speed = 10Mb/s. This problem is repeated in linux 3.10, 4.19, 5.4, 6.12. This problem also exists on the latest kernel. Both drivers call mii_ethtool_get_link_ksettings, but the value of cmd->base.speed in this function can only be SPEED_1000 or SPEED_100 or SPEED_10. When the network cable is not connected, set cmd->base.speed =SPEED_UNKNOWN. Signed-off-by: Xiangqian Zhang Link: https://patch.msgid.link/20250117094603.4192594-1-zhangxiangqian@kylinos.cn Signed-off-by: Jakub Kicinski --- drivers/net/mii.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/mii.c b/drivers/net/mii.c index 22680f47385d5..37bc3131d31a8 100644 --- a/drivers/net/mii.c +++ b/drivers/net/mii.c @@ -213,6 +213,9 @@ void mii_ethtool_get_link_ksettings(struct mii_if_info *mii, lp_advertising = 0; } + if (!(bmsr & BMSR_LSTATUS)) + cmd->base.speed = SPEED_UNKNOWN; + mii->full_duplex = cmd->base.duplex; ethtool_convert_legacy_u32_to_link_mode(cmd->link_modes.supported, -- 2.50.1