From f6302b0ffebb0bd04ff2e8635b4ef9fb33c7188a Mon Sep 17 00:00:00 2001 From: "Darrick J. Wong" Date: Tue, 30 Oct 2018 16:51:36 -0500 Subject: [PATCH] xfs_scrub: lack of kernel support is not a service failure Don't treat a lack of kernel support for scrubbing as an automated service failure because we have not actually determined that there's anything wrong with the filesystem. Signed-off-by: Darrick J. Wong Reviewed-by: Eric Sandeen Signed-off-by: Eric Sandeen --- scrub/xfs_scrub.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scrub/xfs_scrub.c b/scrub/xfs_scrub.c index a789b6f4c..b81380001 100644 --- a/scrub/xfs_scrub.c +++ b/scrub/xfs_scrub.c @@ -780,9 +780,15 @@ out: * for capturing all the log messages if the scrub fails, because the * fail service uses the service name to gather log messages for the * error report. + * + * Note: We don't count a lack of kernel support as a service failure + * because we haven't determined that there's anything wrong with the + * filesystem. */ if (is_service) { sleep(2); + if (!ctx.scrub_setup_succeeded) + return 0; if (ret != SCRUB_RET_SUCCESS) return 1; } -- 2.50.1