From f1011ba20b83da3ee70dcb4a6d9d282a718916fa Mon Sep 17 00:00:00 2001 From: Ma Ke Date: Mon, 22 Jul 2024 22:18:22 +0800 Subject: [PATCH] spi: ppc4xx: handle irq_of_parse_and_map() errors Zero and negative number is not a valid IRQ for in-kernel code and the irq_of_parse_and_map() function returns zero on error. So this check for valid IRQs should only accept values > 0. Fixes: 44dab88e7cc9 ("spi: add spi_ppc4xx driver") Signed-off-by: Ma Ke Link: https://patch.msgid.link/20240722141822.1052370-1-make24@iscas.ac.cn Signed-off-by: Mark Brown --- drivers/spi/spi-ppc4xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-ppc4xx.c b/drivers/spi/spi-ppc4xx.c index 01fdecbf132d..599c29a31269 100644 --- a/drivers/spi/spi-ppc4xx.c +++ b/drivers/spi/spi-ppc4xx.c @@ -416,6 +416,9 @@ static int spi_ppc4xx_of_probe(struct platform_device *op) if (hw->irqnum <= 0) goto free_host; + if (hw->irqnum <= 0) + goto free_host; + ret = request_irq(hw->irqnum, spi_ppc4xx_int, 0, "spi_ppc4xx_of", (void *)hw); if (ret) { -- 2.50.1