From e9647a08bb4613227fd371752910cb32e54f8870 Mon Sep 17 00:00:00 2001 From: Daniel Lenski Date: Thu, 31 May 2018 18:25:15 +0300 Subject: [PATCH] fix typo in Juniper TOTP form name MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit There's a thread from November 2017 in which Kevin Cernekee and Andy Wang discuss a Juniper VPN where TOTP fails to work: http://lists.infradead.org/pipermail/openconnect-devel/2017-November/004569.html … and in that thread both "ftmTotpToken" and "frmTotpToken" are mentioned. It appears that the reason for the misbehavior discussed in the November 2017 is because of the (overlooked) typo in the code. I'm not sure how the "ftm" version got committed in the first place. ¯\_(ツ)_/¯. I did a bit of archeological digging, and I can't find the original patch (from November 29, 2016) anywhere on the mailing list, but it's obviously in the Git history: http://git.infradead.org/users/dwmw2/openconnect.git/commitdiff/1ff34cb9689fbaf57decac537df1e32e799bb9c7 Signed-off-by: Daniel Lenski Signed-off-by: David Woodhouse --- auth-juniper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/auth-juniper.c b/auth-juniper.c index eee85d2f..acd9c77e 100644 --- a/auth-juniper.c +++ b/auth-juniper.c @@ -77,7 +77,7 @@ static int oncp_can_gen_tokencode(struct openconnect_info *vpninfo, if (strcmp(form->auth_id, "frmDefender") && strcmp(form->auth_id, "frmNextToken") && - strcmp(form->auth_id, "ftmTotpToken")) + strcmp(form->auth_id, "frmTotpToken")) return -EINVAL; return can_gen_tokencode(vpninfo, form, opt); -- 2.49.0