From e35666dec64bc9bee143c358533e2538f97cfa2b Mon Sep 17 00:00:00 2001 From: Hadar Hen Zion Date: Mon, 4 Mar 2013 13:53:37 +0200 Subject: [PATCH] IB/mlx4: Fix Coverity issues Signed-off-by: Itai Garbi Signed-off-by: Hadar Hen Zion (Ported from Mellanox OFED 2.4) Signed-off-by: Mukesh Kacker --- drivers/infiniband/hw/mlx4/cq.c | 1 + drivers/infiniband/hw/mlx4/qp.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx4/cq.c b/drivers/infiniband/hw/mlx4/cq.c index afcbd1025ffe..50418728e679 100644 --- a/drivers/infiniband/hw/mlx4/cq.c +++ b/drivers/infiniband/hw/mlx4/cq.c @@ -777,6 +777,7 @@ repoll: switch (cqe->owner_sr_opcode & MLX4_CQE_OPCODE_MASK) { case MLX4_OPCODE_RDMA_WRITE_IMM: wc->wc_flags |= IB_WC_WITH_IMM; + /* fall through */ case MLX4_OPCODE_RDMA_WRITE: wc->opcode = IB_WC_RDMA_WRITE; break; diff --git a/drivers/infiniband/hw/mlx4/qp.c b/drivers/infiniband/hw/mlx4/qp.c index eb4057dd487c..975d488b19e6 100644 --- a/drivers/infiniband/hw/mlx4/qp.c +++ b/drivers/infiniband/hw/mlx4/qp.c @@ -725,7 +725,7 @@ static int create_qp_common(struct mlx4_ib_dev *dev, struct ib_pd *pd, int shift; int n; - if (ib_copy_from_udata(&ucmd, udata, sizeof ucmd)) { + if (!udata || ib_copy_from_udata(&ucmd, udata, sizeof(ucmd))) { err = -EFAULT; goto err; } -- 2.50.1