From dd36660559fb3dcaf4c1ec0be2fbbce19404780b Mon Sep 17 00:00:00 2001 From: Bill O'Donnell Date: Wed, 29 Jun 2016 11:13:03 +1000 Subject: [PATCH] xfs_repair: resolve Coverity OVERFLOW_BEFORE_WIDEN Coverity complains that when multiplying two 32 bit values that eventually will be stored in a 64 bit value that it's possible the math could overflow unless one of the values being multiplied is type cast to the proper size. Signed-off-by: Bill O'Donnell Reviewed-by: Eric Sandeen Signed-off-by: Dave Chinner --- repair/sb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/repair/sb.c b/repair/sb.c index 39659532d..8d4843cb7 100644 --- a/repair/sb.c +++ b/repair/sb.c @@ -230,7 +230,7 @@ find_secondary_sb(xfs_sb_t *rsb) do_warn(_("\nattempting to find secondary superblock...\n")); if (verify_sb_blocksize(rsb) == 0) { - skip = rsb->sb_agblocks * rsb->sb_blocksize; + skip = (__uint64_t)rsb->sb_agblocks * rsb->sb_blocksize; if (skip >= XFS_AG_MIN_BYTES && skip <= XFS_AG_MAX_BYTES) retval = __find_secondary_sb(rsb, skip, skip); } -- 2.50.1