From dafa92f94c5dae0bdf795ba71ed5d607eaa5253a Mon Sep 17 00:00:00 2001 From: Maurizio Lombardi Date: Tue, 8 Nov 2022 15:41:14 +0100 Subject: [PATCH] plugins/micron: fix freed memory dereference. dev_close() is already called after the jump to "out". Calling it 2 times against the same pointer is unsafe because it will dereference freed memory. Signed-off-by: Maurizio Lombardi --- plugins/micron/micron-nvme.c | 1 - 1 file changed, 1 deletion(-) diff --git a/plugins/micron/micron-nvme.c b/plugins/micron/micron-nvme.c index e6f3a8cf..3c0904c4 100644 --- a/plugins/micron/micron-nvme.c +++ b/plugins/micron/micron-nvme.c @@ -3168,7 +3168,6 @@ static int micron_internal_logs(int argc, char **argv, struct command *cmd, if (telemetry_option) { if ((ctrl.lpa & 0x8) != 0x8) { printf("telemetry option is not supported for specified drive\n"); - dev_close(dev); goto out; } int logSize = 0; __u8 *buffer = NULL; const char *dir = "."; -- 2.50.1