From d7c96681380e1563308d06e6066572e84c4584d8 Mon Sep 17 00:00:00 2001 From: Miklos Szeredi Date: Thu, 1 Sep 2016 11:12:00 +0200 Subject: [PATCH] ovl: copyattr after setting POSIX ACL Setting POSIX acl may also modify the file mode, so need to copy that up to the overlay inode. Reported-by: Eryu Guan Fixes: d837a49bd57f ("ovl: fix POSIX ACL setting") Signed-off-by: Miklos Szeredi Orabug: 26401569 (backport upstream commit ce31513a9114f74fe3e9caa6534d201bdac7238d) call d_inode to get inode from dentry. Signed-off-by: Shan Hai Reviewed-by: Somasundaram Krishnasamy --- fs/overlayfs/super.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c index 7d6fbe73bd49..5fdfc7471fd7 100644 --- a/fs/overlayfs/super.c +++ b/fs/overlayfs/super.c @@ -919,7 +919,12 @@ ovl_posix_acl_xattr_set(struct dentry *dentry, const char *name, posix_acl_release(acl); - return ovl_xattr_set(dentry, name, value, size, flags); + err = ovl_xattr_set(dentry, name, value, size, flags); + if (!err) + ovl_copyattr(ovl_inode_real(d_inode(dentry), NULL), + d_inode(dentry)); + + return err; out_acl_release: posix_acl_release(acl); -- 2.50.1