From cffe1f7301b52315a2c4b4d9483df04e991f0948 Mon Sep 17 00:00:00 2001 From: Tomas Jedlicka Date: Thu, 29 Jun 2017 07:22:52 -0400 Subject: [PATCH] dtrace: DTrace state deadman must use dtrace_sync() The dtrace_sync() allows to check that all CPUs have left probe context. Wihtout this code the deadman check would based its assumption on the state of CPU that calls deadman cyclics which is wrong. Orabug: 26385102 Signed-off-by: Tomas Jedlicka Reviewed-by: Kris Van Hees --- dtrace/dtrace_state.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/dtrace/dtrace_state.c b/dtrace/dtrace_state.c index 2098d4e29bd5..e04214bae6c1 100644 --- a/dtrace/dtrace_state.c +++ b/dtrace/dtrace_state.c @@ -301,12 +301,7 @@ static void dtrace_state_clean(dtrace_state_t *state, ktime_t when) static void dtrace_state_deadman(dtrace_state_t *state, ktime_t when) { -#ifdef FIXME - /* - * This may not be needed for Linux - we'll see. - */ dtrace_sync(); -#endif if (state != dtrace_anon.dta_state && time_after_eq(jiffies, state->dts_laststatus + dtrace_deadman_user)) -- 2.50.1