From cabf051afb82bf38c40fca84a3daf36aacbe606c Mon Sep 17 00:00:00 2001 From: Ye Liu Date: Thu, 16 Oct 2025 13:49:25 +0800 Subject: [PATCH] tools/mm/page_owner_sort: add help option support Add -h/--help option to display usage information and improve code style. Link: https://lkml.kernel.org/r/20251016054927.138510-1-ye.liu@linux.dev Signed-off-by: Ye Liu Cc: SeongJae Park Signed-off-by: Andrew Morton --- tools/mm/page_owner_sort.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/mm/page_owner_sort.c b/tools/mm/page_owner_sort.c index 894a765652ac..14c67e9e84c4 100644 --- a/tools/mm/page_owner_sort.c +++ b/tools/mm/page_owner_sort.c @@ -667,14 +667,15 @@ int main(int argc, char **argv) { "pid", required_argument, NULL, 1 }, { "tgid", required_argument, NULL, 2 }, { "name", required_argument, NULL, 3 }, - { "cull", required_argument, NULL, 4 }, - { "sort", required_argument, NULL, 5 }, + { "cull", required_argument, NULL, 4 }, + { "sort", required_argument, NULL, 5 }, + { "help", no_argument, NULL, 'h' }, { 0, 0, 0, 0}, }; compare_flag = COMP_NO_FLAG; - while ((opt = getopt_long(argc, argv, "admnpstP", longopts, NULL)) != -1) + while ((opt = getopt_long(argc, argv, "admnpstPh", longopts, NULL)) != -1) switch (opt) { case 'a': compare_flag |= COMP_ALLOC; @@ -700,6 +701,9 @@ int main(int argc, char **argv) case 'n': compare_flag |= COMP_COMM; break; + case 'h': + usage(); + exit(0); case 1: filter = filter | FILTER_PID; fc.pids = parse_nums_list(optarg, &fc.pids_size); -- 2.51.0