From b347809061bbe94dcd39d38306139944ec2f57b8 Mon Sep 17 00:00:00 2001 From: Sowmini Varadhan Date: Thu, 6 Jul 2017 08:15:07 -0700 Subject: [PATCH] net/sock: add WARN_ON(parent->sk) in sock_graft() sock_graft() unilaterally sets up parent->sk based on the assumption that the existing parent->sk is null. If this condition is not true, then the existing parent->sk would be leaked, so add a WARN_ON() to alert callers who may fall in this category. Orabug: 26477756 Signed-off-by: Sowmini Varadhan Reviewed-by: Yuval Shaia --- include/net/sock.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/net/sock.h b/include/net/sock.h index 5374c0dff793..71431f99fcfc 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -1686,6 +1686,7 @@ static inline void sock_orphan(struct sock *sk) static inline void sock_graft(struct sock *sk, struct socket *parent) { + WARN_ON(parent->sk); write_lock_bh(&sk->sk_callback_lock); sk->sk_wq = parent->wq; parent->sk = sk; -- 2.50.1