From a6f7793000df068282d07ff732342dd2ea92f17c Mon Sep 17 00:00:00 2001 From: Dotan Barak Date: Thu, 12 Jul 2012 11:40:16 +0300 Subject: [PATCH] net/mlx4_core: add sanity check when creating bitmap structure If a user tries to allocate bitmap structure with invalid values, this may cause a kernel panic. Signed-off-by: Dotan Barak Reviewed-by: Yishai Hadas (Ported from Mellanox OFED 2.4) Signed-off-by: Mukesh Kacker --- drivers/net/ethernet/mellanox/mlx4/alloc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx4/alloc.c b/drivers/net/ethernet/mellanox/mlx4/alloc.c index 0c51c69f802f..eb6d038f5de9 100644 --- a/drivers/net/ethernet/mellanox/mlx4/alloc.c +++ b/drivers/net/ethernet/mellanox/mlx4/alloc.c @@ -173,6 +173,10 @@ void mlx4_bitmap_free_range(struct mlx4_bitmap *bitmap, u32 obj, int cnt, int mlx4_bitmap_init(struct mlx4_bitmap *bitmap, u32 num, u32 mask, u32 reserved_bot, u32 reserved_top) { + /* sanity check */ + if (num <= (u64)reserved_top + reserved_bot) + return -EINVAL; + /* num must be a power of 2 */ if (num != roundup_pow_of_two(num)) return -EINVAL; -- 2.50.1