From a6784b2c9cb24e5fa69d4924a20949dd2b31b734 Mon Sep 17 00:00:00 2001 From: Daniel Lenski Date: Sat, 31 Jul 2021 07:42:12 -0700 Subject: [PATCH] Use sysctl to un-disable IPv6 for all CI runs where PPP tests are enabled See https://gitlab.com/openconnect/openconnect/-/issues/287#note_640115686, and https://gitlab.com/openconnect/vpnc-scripts/-/issues/12#note_547951023 for where this issue was originally discovered (specifically on the Ubuntu 18.04 CI runs). Signed-off-by: Daniel Lenski --- .gitlab-ci.yml | 46 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 7c9949cd..2db1fa82 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -21,6 +21,12 @@ CentOS7/GnuTLS: # Flask-based authentication tests. - ./configure --with-java --enable-ppp-tests --disable-flask-tests CFLAGS=-g - make -j4 +# For reasons that are unclear, but probably also unimportant, IPv6 is disabled by default on this CI +# image (verified in https://gitlab.com/openconnect/openconnect/-/jobs/1135199323#L335), and this will +# cause PPP tests using IPv6 to fail. So we must explicitly enable IPv6: + - sysctl net.ipv6.conf.all.disable_ipv6=0 +# we don't want pppd to invoke any actual connection scripts + - mv /etc/ppp /etc/ppp.DISABLED # auth-nonascii: UTF-8 support is not available in distro's ocserv package - make VERBOSE=1 XFAIL_TESTS="auth-nonascii" -j4 check tags: @@ -43,6 +49,10 @@ CentOS7/OpenSSL: # Flask-based authentication tests. - ./configure --without-gnutls --with-openssl --with-java --without-openssl-version-check --enable-dtls-xfail --disable-dsa-tests --enable-ppp-tests --disable-flask-tests CFLAGS=-g - make -j4 +# For reasons that are unclear, but probably also unimportant, IPv6 is disabled by default on this CI +# image (verified in https://gitlab.com/openconnect/openconnect/-/jobs/1135199323#L335), and this will +# cause PPP tests using IPv6 to fail. So we must explicitly enable IPv6: + - sysctl net.ipv6.conf.all.disable_ipv6=0 # we don't want pppd to invoke any actual connection scripts - mv /etc/ppp /etc/ppp.DISABLED # auth-nonascii: UTF-8 support is not available in distro's ocserv package @@ -65,6 +75,10 @@ CentOS8/GnuTLS: - ./autogen.sh - ./configure --with-java --without-gnutls-version-check --disable-dsa-tests --enable-ppp-tests CFLAGS=-g - make -j4 +# For reasons that are unclear, but probably also unimportant, IPv6 is disabled by default on this CI +# image (verified in https://gitlab.com/openconnect/openconnect/-/jobs/1135199323#L335), and this will +# cause PPP tests using IPv6 to fail. So we must explicitly enable IPv6: + - sysctl net.ipv6.conf.all.disable_ipv6=0 # we don't want pppd to invoke any actual connection scripts - mv /etc/ppp /etc/ppp.DISABLED # auth-nonascii: UTF-8 support is not available in distro's ocserv package @@ -86,6 +100,10 @@ CentOS8/OpenSSL: - ./autogen.sh - ./configure --without-gnutls --with-openssl --with-java --without-openssl-version-check --disable-dsa-tests --enable-ppp-tests CFLAGS=-g - make -j4 +# For reasons that are unclear, but probably also unimportant, IPv6 is disabled by default on this CI +# image (verified in https://gitlab.com/openconnect/openconnect/-/jobs/1135199323#L335), and this will +# cause PPP tests using IPv6 to fail. So we must explicitly enable IPv6: + - sysctl net.ipv6.conf.all.disable_ipv6=0 # we don't want pppd to invoke any actual connection scripts - mv /etc/ppp /etc/ppp.DISABLED # auth-nonascii: UTF-8 support is not available in distro's ocserv package @@ -268,6 +286,10 @@ Fedora/GnuTLS: - TMPDISTDIR=../openconnect-$(git describe --tags | sed s/^v//) - ${TMPDISTDIR}/configure --with-java --disable-dsa-tests --without-gnutls-version-check --enable-ppp-tests CFLAGS=-g - make -j4 +# For reasons that are unclear, but probably also unimportant, IPv6 is disabled by default on this CI +# image (verified in https://gitlab.com/openconnect/openconnect/-/jobs/1135199323#L335), and this will +# cause PPP tests using IPv6 to fail. So we must explicitly enable IPv6: + - sysctl net.ipv6.conf.all.disable_ipv6=0 # we don't want pppd to invoke any actual connection scripts - mv /etc/ppp /etc/ppp.DISABLED # auth-pkcs11: Disable rdrand to work around https://bugzilla.redhat.com/1831086 @@ -297,6 +319,10 @@ Fedora/GnuTLS/ibmtss: - TMPDISTDIR=../openconnect-$(git describe --tags | sed s/^v//) - ${TMPDISTDIR}/configure --with-java --disable-dsa-tests --without-gnutls-version-check --enable-ppp-tests --with-gnutls-tss2=ibmtss CFLAGS=-g - make -j4 +# For reasons that are unclear, but probably also unimportant, IPv6 is disabled by default on this CI +# image (verified in https://gitlab.com/openconnect/openconnect/-/jobs/1135199323#L335), and this will +# cause PPP tests using IPv6 to fail. So we must explicitly enable IPv6: + - sysctl net.ipv6.conf.all.disable_ipv6=0 # we don't want pppd to invoke any actual connection scripts - mv /etc/ppp /etc/ppp.DISABLED # auth-pkcs11: Disable rdrand to work around https://bugzilla.redhat.com/1831086 @@ -325,6 +351,10 @@ Fedora/GnuTLS/clang: - TMPDISTDIR=../openconnect-$(git describe --tags | sed s/^v//) - ${TMPDISTDIR}/configure --with-java --disable-dsa-tests --without-gnutls-version-check CC=clang --enable-ppp-tests CFLAGS=-g - make -j4 +# For reasons that are unclear, but probably also unimportant, IPv6 is disabled by default on this CI +# image (verified in https://gitlab.com/openconnect/openconnect/-/jobs/1135199323#L335), and this will +# cause PPP tests using IPv6 to fail. So we must explicitly enable IPv6: + - sysctl net.ipv6.conf.all.disable_ipv6=0 # we don't want pppd to invoke any actual connection scripts - mv /etc/ppp /etc/ppp.DISABLED # auth-pkcs11: Disable rdrand to work around https://bugzilla.redhat.com/1831086 @@ -355,6 +385,10 @@ Fedora/OpenSSL: - TMPDISTDIR=../openconnect-$(git describe --tags | sed s/^v//) - ${TMPDISTDIR}/configure --without-gnutls --with-openssl --without-openssl-version-check --disable-dsa-tests --enable-ppp-tests CFLAGS=-g - make -j4 +# For reasons that are unclear, but probably also unimportant, IPv6 is disabled by default on this CI +# image (verified in https://gitlab.com/openconnect/openconnect/-/jobs/1135199323#L335), and this will +# cause PPP tests using IPv6 to fail. So we must explicitly enable IPv6: + - sysctl net.ipv6.conf.all.disable_ipv6=0 # we don't want pppd to invoke any actual connection scripts - mv /etc/ppp /etc/ppp.DISABLED # auth-nonascii: UTF-8 support is not available in distro's ocserv package @@ -383,6 +417,10 @@ Fedora/OpenSSL/clang: - TMPDISTDIR=../openconnect-$(git describe --tags | sed s/^v//) - ${TMPDISTDIR}/configure CC=clang --without-gnutls --with-openssl --without-openssl-version-check --disable-dsa-tests --enable-ppp-tests CFLAGS=-g - make -j4 +# For reasons that are unclear, but probably also unimportant, IPv6 is disabled by default on this CI +# image (verified in https://gitlab.com/openconnect/openconnect/-/jobs/1135199323#L335), and this will +# cause PPP tests using IPv6 to fail. So we must explicitly enable IPv6: + - sysctl net.ipv6.conf.all.disable_ipv6=0 # we don't want pppd to invoke any actual connection scripts - mv /etc/ppp /etc/ppp.DISABLED # obsolete-server-crypto: OpenSSL 1.1.0 disables 3DES and RC4 by default (https://www.openssl.org/blog/blog/2016/08/24/sweet32/) @@ -404,6 +442,10 @@ Ubuntu18.04/GnuTLS: - ./autogen.sh - ./configure --with-java --enable-ppp-tests CFLAGS=-g - make -j4 +# For reasons that are unclear, but probably also unimportant, IPv6 is disabled by default on this CI +# image (verified in https://gitlab.com/openconnect/openconnect/-/jobs/1135199323#L335), and this will +# cause PPP tests using IPv6 to fail. So we must explicitly enable IPv6: + - sysctl net.ipv6.conf.all.disable_ipv6=0 # we don't want pppd to invoke any actual connection scripts - mv /etc/ppp /etc/ppp.DISABLED # For reasons that are unclear, but probably also unimportant, IPv6 is disabled by default on this CI @@ -428,6 +470,10 @@ Ubuntu18.04/OpenSSL: - ./autogen.sh - ./configure --without-gnutls --with-openssl --with-java --without-openssl-version-check --disable-dsa-tests --enable-ppp-tests CFLAGS=-g - make -j4 +# For reasons that are unclear, but probably also unimportant, IPv6 is disabled by default on this CI +# image (verified in https://gitlab.com/openconnect/openconnect/-/jobs/1135199323#L335), and this will +# cause PPP tests using IPv6 to fail. So we must explicitly enable IPv6: + - sysctl net.ipv6.conf.all.disable_ipv6=0 # we don't want pppd to invoke any actual connection scripts - mv /etc/ppp /etc/ppp.DISABLED # For reasons that are unclear, but probably also unimportant, IPv6 is disabled by default on this CI -- 2.50.1