From a500b151b292e770ec7d6af914ec72dddb2adc98 Mon Sep 17 00:00:00 2001 From: Andrey Konovalov Date: Wed, 14 Aug 2024 18:10:52 +0200 Subject: [PATCH] kasan-simplify-and-clarify-makefile-v2 comments fixes per Miguel Link: https://lkml.kernel.org/r/20240814161052.10374-1-andrey.konovalov@linux.dev Signed-off-by: Andrey Konovalov Reviewed-by: Miguel Ojeda Signed-off-by: Andrew Morton --- scripts/Makefile.kasan | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/Makefile.kasan b/scripts/Makefile.kasan index 04b108f311d2..aab4154af00a 100644 --- a/scripts/Makefile.kasan +++ b/scripts/Makefile.kasan @@ -34,13 +34,15 @@ endif # First, enable -fsanitize=kernel-address together with providing the shadow # mapping offset, as for GCC, -fasan-shadow-offset fails without -fsanitize # (GCC accepts the shadow mapping offset via -fasan-shadow-offset instead of -# a normal --param). Instead of ifdef-checking the compiler, rely on cc-option. +# a --param like the other KASAN parameters). +# Instead of ifdef-checking the compiler, rely on cc-option. CFLAGS_KASAN := $(call cc-option, -fsanitize=kernel-address \ -fasan-shadow-offset=$(KASAN_SHADOW_OFFSET), \ $(call cc-option, -fsanitize=kernel-address \ -mllvm -asan-mapping-offset=$(KASAN_SHADOW_OFFSET))) -# Now, add other parameters enabled in a similar way with GCC and Clang. +# Now, add other parameters enabled similarly in both GCC and Clang. +# As some of them are not supported by older compilers, use cc-param. CFLAGS_KASAN += $(call cc-param,asan-instrumentation-with-call-threshold=$(call_threshold)) \ $(call cc-param,asan-stack=$(stack_enable)) \ $(call cc-param,asan-instrument-allocas=1) \ -- 2.49.0