From a4cb9066283dbca2c06089766459568156670566 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Tue, 4 Mar 2025 15:27:59 +0100 Subject: [PATCH] pmdomain: rockchip: add regulator dependency When CONFIG_REGULATOR is disabled, this pmdomain driver fails to build: drivers/pmdomain/rockchip/pm-domains.c:653:30: error: implicit declaration of function 'devm_of_regulator_get'; did you mean 'devm_regulator_get'? [-Wimplicit-function-declaration] 653 | pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain"); | ^~~~~~~~~~~~~~~~~~~~~ | devm_regulator_get drivers/pmdomain/rockchip/pm-domains.c:653:28: error: assignment to 'struct regulator *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 653 | pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain"); | ^ Add a Kconfig dependency. Fixes: db6df2e3fc16 ("pmdomain: rockchip: add regulator support") Signed-off-by: Arnd Bergmann Reviewed-by: Sebastian Reichel Reviewed-by: Dragan Simic Reviewed-by: Heiko Stuebner Link: https://lore.kernel.org/r/20250304142803.689201-1-arnd@kernel.org Signed-off-by: Ulf Hansson --- drivers/pmdomain/rockchip/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pmdomain/rockchip/Kconfig b/drivers/pmdomain/rockchip/Kconfig index 7e4f9b628f0b..218d43186e5b 100644 --- a/drivers/pmdomain/rockchip/Kconfig +++ b/drivers/pmdomain/rockchip/Kconfig @@ -5,6 +5,7 @@ config ROCKCHIP_PM_DOMAINS bool "Rockchip generic power domain" depends on PM depends on HAVE_ARM_SMCCC_DISCOVERY + depends on REGULATOR select PM_GENERIC_DOMAINS help Say y here to enable power domain support. -- 2.50.1