From a2d3b257b4ea85b5e1753177a99785b12c865677 Mon Sep 17 00:00:00 2001 From: Wu Bo Date: Wed, 6 May 2020 11:26:54 +0800 Subject: [PATCH] nvme-cli:nvme:fix fd leak when an error occurs --- nvme.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/nvme.c b/nvme.c index 64b5750..f4218a3 100644 --- a/nvme.c +++ b/nvme.c @@ -148,10 +148,13 @@ static int open_dev(char *dev) fd = err; err = fstat(fd, &nvme_stat); - if (err < 0) + if (err < 0) { + close(fd); goto perror; + } if (!S_ISCHR(nvme_stat.st_mode) && !S_ISBLK(nvme_stat.st_mode)) { fprintf(stderr, "%s is not a block or character device\n", dev); + close(fd); return -ENODEV; } return fd; -- 2.49.0