From 9ee9e050a488be6d66c16f6e3cd15d7ebfc3411e Mon Sep 17 00:00:00 2001 From: Stephen Cameron Date: Fri, 6 Nov 2015 05:47:40 -0800 Subject: [PATCH] hpsa: do not ignore return value of hpsa_register_scsi add error handling for failure when registering with SCSI subsystem. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace Orabug: 22075051 Acked-by: Chuck Anderson --- drivers/scsi/hpsa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 2e4ef069469f..6f8875672f9a 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -7407,7 +7407,9 @@ reinit_after_soft_reset: h->access.set_intr_mask(h, HPSA_INTR_ON); hpsa_hba_inquiry(h); - hpsa_register_scsi(h); /* hook ourselves into SCSI subsystem */ + rc = hpsa_register_scsi(h); /* hook ourselves into SCSI subsystem */ + if (rc) + goto clean4; /* Monitor the controller for firmware lockups */ h->heartbeat_sample_interval = HEARTBEAT_SAMPLE_INTERVAL; -- 2.50.1