From 9a1accd3a57d4bfb6daeee2262b1b24b57ec2382 Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Thu, 29 May 2025 20:06:01 -0400 Subject: [PATCH] bcachefs: Journal keys are retained until shutdown, or journal replay finishes If we don't finish journal replay we need to keep journal keys around until the filesystem shuts down - otherwise e.g. -o norecovery, various tools (dump, list) break, and eventually we'll be doing journal replay in the background. Signed-off-by: Kent Overstreet --- fs/bcachefs/recovery.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/bcachefs/recovery.c b/fs/bcachefs/recovery.c index 4fca575755657..4b51105bdb2e1 100644 --- a/fs/bcachefs/recovery.c +++ b/fs/bcachefs/recovery.c @@ -1093,10 +1093,6 @@ use_clean: out: bch2_flush_fsck_errs(c); - if (!c->opts.retain_recovery_info) { - bch2_journal_keys_put_initial(c); - bch2_find_btree_nodes_exit(&c->found_btree_nodes); - } if (!IS_ERR(clean)) kfree(clean); -- 2.50.1