From 99012014c902cd9ad85fd288d8a107f33a69855e Mon Sep 17 00:00:00 2001 From: Ulf Hansson Date: Wed, 2 Apr 2025 14:06:13 +0200 Subject: [PATCH] pmdomain: core: Reset genpd->states to avoid freeing invalid data If genpd_alloc_data() allocates data for the default power-states for the genpd, let's make sure to also reset the pointer in the error path. This makes sure a genpd provider driver doesn't end up trying to free the data again, but using an invalid pointer. Signed-off-by: Ulf Hansson Reviewed-by: Dhruva Gole Link: https://lore.kernel.org/r/20250402120613.1116711-1-ulf.hansson@linaro.org --- drivers/pmdomain/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pmdomain/core.c b/drivers/pmdomain/core.c index 3327de2f9ed2..3523d0331cec 100644 --- a/drivers/pmdomain/core.c +++ b/drivers/pmdomain/core.c @@ -2287,8 +2287,10 @@ static int genpd_alloc_data(struct generic_pm_domain *genpd) return 0; put: put_device(&genpd->dev); - if (genpd->free_states == genpd_free_default_power_state) + if (genpd->free_states == genpd_free_default_power_state) { kfree(genpd->states); + genpd->states = NULL; + } free: if (genpd_is_cpu_domain(genpd)) free_cpumask_var(genpd->cpus); -- 2.50.1