From 9769ef4d539ca11549f3de8fd6710892e870acb5 Mon Sep 17 00:00:00 2001 From: Daniel Wagner Date: Tue, 7 Feb 2023 09:30:42 +0100 Subject: [PATCH] fabrics: Do not ignore one char whitespace when string sanitizing strchomp() is handling the max length of a string correctly. Reported-by: calebsander Signed-off-by: Daniel Wagner --- src/nvme/fabrics.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/nvme/fabrics.c b/src/nvme/fabrics.c index 7134dbae..1c252168 100644 --- a/src/nvme/fabrics.c +++ b/src/nvme/fabrics.c @@ -894,20 +894,20 @@ static void sanitize_discovery_log_entry(struct nvmf_disc_log_entry *e) switch (e->adrfam) { case NVMF_ADDR_FAMILY_IP4: case NVMF_ADDR_FAMILY_IP6: - strchomp(e->traddr, NVMF_TRADDR_SIZE - 1); - strchomp(e->trsvcid, NVMF_TRSVCID_SIZE - 1); + strchomp(e->traddr, NVMF_TRADDR_SIZE); + strchomp(e->trsvcid, NVMF_TRSVCID_SIZE); break; } break; case NVMF_TRTYPE_FC: switch (e->adrfam) { case NVMF_ADDR_FAMILY_FC: - strchomp(e->traddr, NVMF_TRADDR_SIZE - 1); + strchomp(e->traddr, NVMF_TRADDR_SIZE); break; } break; case NVMF_TRTYPE_LOOP: - strchomp(e->traddr, NVMF_TRADDR_SIZE - 1); + strchomp(e->traddr, NVMF_TRADDR_SIZE); break; } } -- 2.50.1