From 95e65f2d0bdef883b09b7044b1435a36819ae38a Mon Sep 17 00:00:00 2001 From: Pavel Begunkov Date: Wed, 19 Feb 2025 10:09:54 +0000 Subject: [PATCH] io_uring/zcrx: fix leaks on failed registration If we try to register a device-less interface like veth, io_register_zcrx_ifq() will leak struct io_zcrx_ifq with a bunch of resources attached to it. Fix that. Fixes: 035af94b39fd ("io_uring/zcrx: grab a net device") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202502190532.W7NnmyiP-lkp@intel.com/ Signed-off-by: Pavel Begunkov Link: https://lore.kernel.org/r/fbf16279dd73fa4c6df048168728355636ba5f53.1739959771.git.asml.silence@gmail.com Signed-off-by: Jens Axboe --- io_uring/zcrx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/io_uring/zcrx.c b/io_uring/zcrx.c index a9eaab3fccf2..f2d326e18e67 100644 --- a/io_uring/zcrx.c +++ b/io_uring/zcrx.c @@ -388,8 +388,9 @@ int io_register_zcrx_ifq(struct io_ring_ctx *ctx, goto err; ifq->dev = ifq->netdev->dev.parent; + ret = -EOPNOTSUPP; if (!ifq->dev) - return -EOPNOTSUPP; + goto err; get_device(ifq->dev); ret = io_zcrx_map_area(ifq, ifq->area); -- 2.50.1