From 95e38bcee09b63c1aaebf323a08ce1b5ed99fc08 Mon Sep 17 00:00:00 2001 From: Venkat Venkatsubra Date: Tue, 20 Dec 2016 11:55:39 -0800 Subject: [PATCH] Some unsupported ioctls get logged unnecessarily IPoIB logs messages such as "ib0: ioctl fail to copy request data". Orabug: 24510137 Acked-by: Yuval Shaia Signed-off-by: Venkat Venkatsubra --- drivers/infiniband/ulp/ipoib/ipoib_ioctl.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ioctl.c b/drivers/infiniband/ulp/ipoib/ipoib_ioctl.c index 993d990f1dd1..1b08d2d6ad76 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_ioctl.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_ioctl.c @@ -47,6 +47,11 @@ int ipoib_do_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) struct ib_cm_acl *acl; char *buf; + if (cmd < IPOIBSTATUSGET || cmd > IPOIBACLDEL) { + ipoib_dbg(priv, "invalid ioctl opcode 0x%x\n", cmd); + return -EOPNOTSUPP; + } + rc = copy_from_user(&req_data, rq->req_data, sizeof(struct ipoib_ioctl_req_data)); if (rc != 0) { @@ -188,10 +193,6 @@ int ipoib_do_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) ib_cm_acl_delete(&priv->acl, subnet_prefix, guid); } break; - default: - ipoib_dbg(priv, "invalid ioctl opcode 0x%x\n", cmd); - rc = -EINVAL; - break; } rc = copy_to_user(rq->req_data, &req_data, -- 2.50.1