From 93bf3dd8d1e10260c0b62055e9215ea3fa808fa4 Mon Sep 17 00:00:00 2001 From: Moshe Lazer Date: Sun, 28 Apr 2013 17:19:17 +0300 Subject: [PATCH] mlx4_core: Avoid setting ports for auto when only one port type is supported When only one port type is supported driver should reject requests to change mode to auto sense. Signed-off-by: Moshe Lazer (Ported from Mellanox OFED 2.4) Signed-off-by: Mukesh Kacker --- drivers/net/ethernet/mellanox/mlx4/main.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c index cd70f679facc5..49f154375cbc6 100644 --- a/drivers/net/ethernet/mellanox/mlx4/main.c +++ b/drivers/net/ethernet/mellanox/mlx4/main.c @@ -1134,6 +1134,13 @@ static ssize_t set_port_type(struct device *dev, goto err_out; } + if ((info->tmp_type & mdev->caps.supported_type[info->port]) != + info->tmp_type) { + mlx4_err(mdev, "Requested port type for port %d is not supported on this HCA\n", + info->port); + return -EINVAL; + } + mlx4_stop_sense(mdev); mutex_lock(&priv->port_mutex); /* Possible type is always the one that was delivered */ -- 2.50.1