From 8f98c342149b231584a1caed12d9448620e21850 Mon Sep 17 00:00:00 2001 From: "Darrick J. Wong" Date: Tue, 28 May 2024 21:11:54 -0700 Subject: [PATCH] xfs: allow inodes with zero extents but nonzero nblocks Metadata inodes that store btrees will have zero extents and a nonzero nblocks. Adjust the inode verifier so that this combination is not flagged. Signed-off-by: Darrick J. Wong --- libxfs/xfs_inode_buf.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/libxfs/xfs_inode_buf.c b/libxfs/xfs_inode_buf.c index 3732636fd..40421629f 100644 --- a/libxfs/xfs_inode_buf.c +++ b/libxfs/xfs_inode_buf.c @@ -639,9 +639,6 @@ xfs_dinode_verify( if (mode && nextents + naextents > nblocks) return __this_address; - if (nextents + naextents == 0 && nblocks != 0) - return __this_address; - if (S_ISDIR(mode) && nextents > mp->m_dir_geo->max_extents) return __this_address; @@ -745,6 +742,19 @@ xfs_dinode_verify( return fa; } + /* metadata inodes containing btrees always have zero extent count */ + if (flags2 & XFS_DIFLAG2_METADATA) { + switch (XFS_DFORK_FORMAT(dip, XFS_DATA_FORK)) { + case XFS_DINODE_FMT_RMAP: + break; + default: + if (nextents + naextents == 0 && nblocks != 0) + return __this_address; + break; + } + } else if (nextents + naextents == 0 && nblocks != 0) + return __this_address; + return NULL; } -- 2.50.1