From 8c93aaa0c6cc939cb288c6f71112eefae46de1e9 Mon Sep 17 00:00:00 2001 From: Hannes Reinecke Date: Fri, 22 Apr 2022 13:14:37 +0200 Subject: [PATCH] plugins/ymtc: fixup resource leaks Found by coverity. Signed-off-by: Hannes Reinecke --- plugins/ymtc/ymtc-nvme.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/plugins/ymtc/ymtc-nvme.c b/plugins/ymtc/ymtc-nvme.c index 5abc1939..7c34798b 100644 --- a/plugins/ymtc/ymtc-nvme.c +++ b/plugins/ymtc/ymtc-nvme.c @@ -30,9 +30,21 @@ static int show_ymtc_smart_log(int fd, __u32 nsid, const char *devname, u8 *nm = malloc(NM_SIZE * sizeof(u8)); u8 *raw = malloc(RAW_SIZE * sizeof(u8)); + if (!nm) { + if (raw) + free(raw); + return -1; + } + if (!raw) { + free(nm); + return -1; + } err = nvme_identify_ctrl(fd, &ctrl); - if (err) + if (err) { + free(nm); + free(raw); return err; + } snprintf(fw_ver, sizeof(fw_ver), "%c.%c%c.%c%c%c%c", ctrl.fr[0], ctrl.fr[1], ctrl.fr[2], ctrl.fr[3], -- 2.50.1