From 8c52766a0128498bdd218410bf4c6ece8d174d7c Mon Sep 17 00:00:00 2001 From: William Kucharski Date: Tue, 21 Oct 2025 05:00:04 -0600 Subject: [PATCH] mm: remove reference to destructor in comment in calculate_sizes() The commit that removed support for destructors from kmem_cache_alloc() never removed the comment regarding destructors in the explanation of the possible relocation of the free pointer in calculate_sizes(). Link: https://lkml.kernel.org/r/20251021110004.2209008-1-william.kucharski@oracle.com Fixes: 20c2df83d25c ("mm: Remove slab destructors from kmem_cache_create().") Signed-off-by: William Kucharski Acked-by: Roman Gushchin Reviewed-by: Christoph Lameter (Ampere) Cc: David Rientjes Cc: Paul Mundt Cc: Vlastimil Babka Cc: Harry Yoo Signed-off-by: Andrew Morton --- mm/slub.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index b7442015f640..708848d3512c 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -7874,11 +7874,11 @@ static int calculate_sizes(struct kmem_cache_args *args, struct kmem_cache *s) * permitted to overwrite the first word of the object on * kmem_cache_free. * - * This is the case if we do RCU, have a constructor or - * destructor, are poisoning the objects, or are - * redzoning an object smaller than sizeof(void *) or are - * redzoning an object with slub_debug_orig_size() enabled, - * in which case the right redzone may be extended. + * This is the case if we do RCU, have a constructor, are + * poisoning the objects, or are redzoning an object smaller + * than sizeof(void *) or are redzoning an object with + * slub_debug_orig_size() enabled, in which case the right + * redzone may be extended. * * The assumption that s->offset >= s->inuse means free * pointer is outside of the object is used in the -- 2.51.0