From 7cedddf549d08b4751c0258890242757c18cf744 Mon Sep 17 00:00:00 2001 From: Steve Hodgson Date: Mon, 12 Nov 2012 12:16:05 -0800 Subject: [PATCH] qla2xxx: Free rsp_data even on error in qla2x00_process_loopback(). JIRA Key: V2632FC-305 Acked-by: Giridhar Malavali Acked-by: Armen Baloyan --- drivers/scsi/qla2xxx/qla_bsg.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c index b1afa77aef1d..05d5b6c7a12a 100644 --- a/drivers/scsi/qla2xxx/qla_bsg.c +++ b/drivers/scsi/qla2xxx/qla_bsg.c @@ -743,7 +743,7 @@ qla2x00_process_loopback(struct fc_bsg_job *bsg_job) ql_log(ql_log_warn, vha, 0x701f, "Get port config failed.\n"); rval = -EPERM; - goto done_free_dma_req; + goto done_free_dma_rsp; } ql_dbg(ql_dbg_user, vha, 0x70c0, @@ -762,7 +762,7 @@ qla2x00_process_loopback(struct fc_bsg_job *bsg_job) if (rval) { rval = -EPERM; - goto done_free_dma_req; + goto done_free_dma_rsp; } type = "FC_BSG_HST_VENDOR_LOOPBACK"; @@ -795,7 +795,7 @@ qla2x00_process_loopback(struct fc_bsg_job *bsg_job) } rval = -EIO; - goto done_free_dma_req; + goto done_free_dma_rsp; } } else { type = "FC_BSG_HST_VENDOR_LOOPBACK"; @@ -832,6 +832,7 @@ qla2x00_process_loopback(struct fc_bsg_job *bsg_job) fw_sts_ptr += sizeof(response); *fw_sts_ptr = command_sent; +done_free_dma_rsp: dma_free_coherent(&ha->pdev->dev, rsp_data_len, rsp_data, rsp_data_dma); done_free_dma_req: -- 2.50.1