From 6fe1152a1f6cd5fadb54b9823d46787bc2a34952 Mon Sep 17 00:00:00 2001 From: Yang Yingliang Date: Thu, 1 Apr 2021 12:35:00 +0200 Subject: [PATCH] media: camss: csiphy: Remove redundant dev_err call in msm_csiphy_subdev_init() There is an error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Reviewed-by: Robert Foss Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/qcom/camss/camss-csiphy.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss-csiphy.c index 6ceb6d7d53d1e..b3c3bf19e5223 100644 --- a/drivers/media/platform/qcom/camss/camss-csiphy.c +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c @@ -593,20 +593,16 @@ int msm_csiphy_subdev_init(struct camss *camss, r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]); csiphy->base = devm_ioremap_resource(dev, r); - if (IS_ERR(csiphy->base)) { - dev_err(dev, "could not map memory\n"); + if (IS_ERR(csiphy->base)) return PTR_ERR(csiphy->base); - } if (camss->version == CAMSS_8x16 || camss->version == CAMSS_8x96) { r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[1]); csiphy->base_clk_mux = devm_ioremap_resource(dev, r); - if (IS_ERR(csiphy->base_clk_mux)) { - dev_err(dev, "could not map memory\n"); + if (IS_ERR(csiphy->base_clk_mux)) return PTR_ERR(csiphy->base_clk_mux); - } } else { csiphy->base_clk_mux = NULL; } -- 2.50.1