From 69db9e831dbf5a44cba9c329089e8a8de8e39bd6 Mon Sep 17 00:00:00 2001 From: Mauro Carvalho Chehab Date: Tue, 16 Jul 2024 10:12:42 +0200 Subject: [PATCH] rbtree.h: Fix an issue introduced by checkpatch logic Checkpatch actually broke RB_EMPTY_ROOT macro. It was defined as: #define RB_EMPTY_ROOT(root) ((root)->rb_node == NULL) It ended replacing it by: ((root)->!rb_node) Which is not the way we espect it. Weird enough, this was compiling. Anyway, what we want, instead, is: #define RB_EMPTY_ROOT(root) (!(root)->rb_node) Signed-off-by: Mauro Carvalho Chehab --- rbtree.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rbtree.h b/rbtree.h index e8c38de..555b3dc 100644 --- a/rbtree.h +++ b/rbtree.h @@ -134,7 +134,7 @@ static inline void rb_set_color(struct rb_node *rb, int color) #define RB_ROOT (struct rb_root) { NULL, } #define rb_entry(ptr, type, member) container_of(ptr, type, member) -#define RB_EMPTY_ROOT(root) ((root)->!rb_node) +#define RB_EMPTY_ROOT(root) (!(root)->rb_node) #define RB_EMPTY_NODE(node) (rb_parent(node) == node) #define RB_CLEAR_NODE(node) (rb_set_parent(node, node)) -- 2.50.1