From 666ff8c15da3a3e00b4386944a2b6792ce745c0e Mon Sep 17 00:00:00 2001 From: Daniel Wagner Date: Mon, 1 Aug 2022 14:22:17 +0200 Subject: [PATCH] nvme: Do not print error message in collect_effects_log helper We print error and status on the top level, so no need to print it a helper. Signed-off-by: Daniel Wagner --- nvme.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/nvme.c b/nvme.c index 61f10fca..0bc88766 100644 --- a/nvme.c +++ b/nvme.c @@ -600,17 +600,12 @@ static int collect_effects_log(int fd, enum nvme_csi csi, node->csi = csi; err = nvme_get_log_cmd_effects(fd, csi, &node->effects); - if (!err) { - list_add(list, &node->node); + if (err) { + free(node); return err; } - else if (err > 0) - nvme_show_status(err); - else - fprintf(stderr, "effects log page: %s\n", nvme_strerror(errno)); - - free(node); - return err; + list_add(list, &node->node); + return 0; } static int get_effects_log(int argc, char **argv, struct command *cmd, struct plugin *plugin) -- 2.50.1