From 618da2dd897233a4a75705df78696755d33ba1ce Mon Sep 17 00:00:00 2001 From: Amir Vadai Date: Tue, 5 Apr 2011 10:58:56 +0300 Subject: [PATCH] sdp: Fixed some coverity issues Signed-off-by: Amir Vadai --- drivers/infiniband/ulp/sdp/sdp_cma.c | 7 ++++++- drivers/infiniband/ulp/sdp/sdp_main.c | 9 ++++++++- drivers/infiniband/ulp/sdp/sdp_rx.c | 2 +- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/ulp/sdp/sdp_cma.c b/drivers/infiniband/ulp/sdp/sdp_cma.c index 09bd41c3e662..434adb317df6 100644 --- a/drivers/infiniband/ulp/sdp/sdp_cma.c +++ b/drivers/infiniband/ulp/sdp/sdp_cma.c @@ -74,11 +74,16 @@ static int sdp_get_max_dev_sge(struct ib_device *dev) { struct ib_device_attr attr; static int max_sges = -1; + int rc; if (max_sges > 0) goto out; - ib_query_device(dev, &attr); + rc = ib_query_device(dev, &attr); + if (rc) { + sdp_warn(NULL, "ib_query_device failed: %d\n", rc); + goto out; + } max_sges = attr.max_sge; diff --git a/drivers/infiniband/ulp/sdp/sdp_main.c b/drivers/infiniband/ulp/sdp/sdp_main.c index dca141f9ba23..de5455e70a55 100644 --- a/drivers/infiniband/ulp/sdp/sdp_main.c +++ b/drivers/infiniband/ulp/sdp/sdp_main.c @@ -2954,10 +2954,17 @@ static int __init sdp_init(void) sdp_proc_init(); - ib_register_client(&sdp_client); + rc = ib_register_client(&sdp_client); + if (rc) { + printk(KERN_WARNING "ib_register_client failed: %d\n", rc); + goto error_ib_reg; + } return 0; +error_ib_reg: + sdp_proc_unregister(); + #if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE) error_sock_reg6: sock_unregister(PF_INET_SDP); diff --git a/drivers/infiniband/ulp/sdp/sdp_rx.c b/drivers/infiniband/ulp/sdp/sdp_rx.c index 704066572f75..8ec2f5d2df34 100644 --- a/drivers/infiniband/ulp/sdp/sdp_rx.c +++ b/drivers/infiniband/ulp/sdp/sdp_rx.c @@ -612,7 +612,7 @@ static int sdp_process_rx_skb(struct sdp_sock *ssk, struct sk_buff *skb) } sdp_prf(sk, NULL, "queueing %s skb", mid2str(h->mid)); - skb = sdp_sock_queue_rcv_skb(sk, skb); + sdp_sock_queue_rcv_skb(sk, skb); return 0; } -- 2.50.1