From 5add9ad11d671960b6094c1ca6b5b752eb1286bc Mon Sep 17 00:00:00 2001 From: Markus Elfring Date: Tue, 23 Jun 2015 22:30:21 +0200 Subject: [PATCH] crypto: jitterentropy - Delete unnecessary checks before the function call "kzfree" Orabug: 26330509 The kzfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Herbert Xu (cherry picked from commit cea0a3c305fa348cfad3bae4a226c241720daf55) Signed-off-by: Somasundaram Krishnasamy Reviewed-by: Jack Vogel --- crypto/jitterentropy.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/crypto/jitterentropy.c b/crypto/jitterentropy.c index 6dfb220b183c..acf44b2d2d1d 100644 --- a/crypto/jitterentropy.c +++ b/crypto/jitterentropy.c @@ -653,11 +653,9 @@ struct rand_data *jent_entropy_collector_alloc(unsigned int osr, void jent_entropy_collector_free(struct rand_data *entropy_collector) { - if (entropy_collector->mem) - jent_zfree(entropy_collector->mem); + jent_zfree(entropy_collector->mem); entropy_collector->mem = NULL; - if (entropy_collector) - jent_zfree(entropy_collector); + jent_zfree(entropy_collector); entropy_collector = NULL; } -- 2.50.1