From 5765161b555dfadc19f6c5fbcb5b61073fe27f7f Mon Sep 17 00:00:00 2001 From: Dotan Barak Date: Wed, 21 Nov 2007 09:08:25 +0200 Subject: [PATCH] SDP: A better fix of a potential memory leak in the new bzcopy code. Signed-off-by: Dotan Barak --- drivers/infiniband/ulp/sdp/sdp_main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/ulp/sdp/sdp_main.c b/drivers/infiniband/ulp/sdp/sdp_main.c index 809f7b8aaf8a..583187c927a7 100644 --- a/drivers/infiniband/ulp/sdp/sdp_main.c +++ b/drivers/infiniband/ulp/sdp/sdp_main.c @@ -1240,10 +1240,6 @@ static struct bzcopy_state *sdp_bz_setup(struct sdp_sock *ssk, if (!can_do_mlock()) return NULL; - bz = kzalloc(sizeof(*bz), GFP_KERNEL); - if (!bz) - return NULL; - /* * Since we use the TCP segmentation fields of the skb to map user * pages, we must make sure that everything we send in a single chunk @@ -1253,6 +1249,10 @@ static struct bzcopy_state *sdp_bz_setup(struct sdp_sock *ssk, if (size_goal >= MAX_SKB_FRAGS) return NULL; + bz = kzalloc(sizeof(*bz), GFP_KERNEL); + if (!bz) + return NULL; + addr = (unsigned long)base; bz->u_base = base; -- 2.50.1