From 4f388c203470e7fb26709cb52184586971387db0 Mon Sep 17 00:00:00 2001
From: Hannes Reinecke <hare@suse.de>
Date: Fri, 11 Mar 2022 09:37:37 +0100
Subject: [PATCH] Document filter functions

Add documentation for the various filter functions.

Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 src/nvme/filters.c | 12 ++++-----
 src/nvme/filters.h | 66 +++++++++++++++++++++++-----------------------
 2 files changed, 39 insertions(+), 39 deletions(-)

diff --git a/src/nvme/filters.c b/src/nvme/filters.c
index b726db69..b5959a8e 100644
--- a/src/nvme/filters.c
+++ b/src/nvme/filters.c
@@ -93,9 +93,9 @@ int nvme_scan_subsystems(struct dirent ***subsys)
 		       alphasort);
 }
 
-int nvme_scan_subsystem_namespaces(nvme_subsystem_t s, struct dirent ***namespaces)
+int nvme_scan_subsystem_namespaces(nvme_subsystem_t s, struct dirent ***ns)
 {
-	return scandir(nvme_subsystem_get_sysfs_dir(s), namespaces,
+	return scandir(nvme_subsystem_get_sysfs_dir(s), ns,
 		       nvme_namespace_filter, alphasort);
 }
 
@@ -105,14 +105,14 @@ int nvme_scan_ctrls(struct dirent ***ctrls)
 		       alphasort);
 }
 
-int nvme_scan_ctrl_namespace_paths(nvme_ctrl_t c, struct dirent ***namespaces)
+int nvme_scan_ctrl_namespace_paths(nvme_ctrl_t c, struct dirent ***paths)
 {
-	return scandir(nvme_ctrl_get_sysfs_dir(c), namespaces,
+	return scandir(nvme_ctrl_get_sysfs_dir(c), paths,
 		       nvme_paths_filter, alphasort);
 }
 
-int nvme_scan_ctrl_namespaces(nvme_ctrl_t c, struct dirent ***namespaces)
+int nvme_scan_ctrl_namespaces(nvme_ctrl_t c, struct dirent ***ns)
 {
-	return scandir(nvme_ctrl_get_sysfs_dir(c), namespaces,
+	return scandir(nvme_ctrl_get_sysfs_dir(c), ns,
 		       nvme_namespace_filter, alphasort);
 }
diff --git a/src/nvme/filters.h b/src/nvme/filters.h
index 9156d5a9..a9e5ec77 100644
--- a/src/nvme/filters.h
+++ b/src/nvme/filters.h
@@ -19,78 +19,78 @@
  */
 
 /**
- * nvme_namespace_filter() -
- * @d:
+ * nvme_namespace_filter() - Filter for namespaces
+ * @d: dirent to check
  *
- * Return: 
+ * Return: 1 if @d matches, 0 otherwise
  */
 int nvme_namespace_filter(const struct dirent *d);
 
 /**
- * nvme_paths_filter() -
- * @d:
+ * nvme_paths_filter() - Filter for paths
+ * @d: dirent to check
  *
- * Return: 
+ * Return: 1 if @d matches, 0 otherwise
  */
 int nvme_paths_filter(const struct dirent *d);
 
 /**
- * nvme_ctrls_filter() -
- * @d:
+ * nvme_ctrls_filter() - Filter for controllers
+ * @d: dirent to check
  *
- * Return: 
+ * Return: 1 if @d matches, 0 otherwise
  */
 int nvme_ctrls_filter(const struct dirent *d);
 
 /**
- * nvme_subsys_filter() -
- * @d:
+ * nvme_subsys_filter() - Filter for subsystems
+ * @d: dirent to check
  *
- * Return: 
+ * Return: 1 if @d matches, 0 otherwise
  */
 int nvme_subsys_filter(const struct dirent *d);
 
 /**
- * nvme_scan_subsystems() -
- * @subsys:
+ * nvme_scan_subsystems() - Scan for subsystems
+ * @subsys: Pointer to array of dirents
  *
- * Return: 
+ * Return: number of entries in @subsys
  */
 int nvme_scan_subsystems(struct dirent ***subsys);
 
 /**
- * nvme_scan_subsystem_namespaces() -
- * @s:
- * @namespaces:
+ * nvme_scan_subsystem_namespaces() - Scan for namespaces in a subsystem
+ * @s: Subsystem to scan
+ * @n: Pointer to array of dirents
  *
- * Return: 
+ * Return: number of entries in @ns
  */
-int nvme_scan_subsystem_namespaces(nvme_subsystem_t s, struct dirent ***namespaces);
+int nvme_scan_subsystem_namespaces(nvme_subsystem_t s, struct dirent ***ns);
 
 /**
- * nvme_scan_ctrls() -
- * @ctrls:
+ * nvme_scan_ctrls() - Scan for controllers
+ * @ctrls: Pointer to array of dirents
  *
- * Return: 
+ * Return: number of entries in @ctrls
  */
 int nvme_scan_ctrls(struct dirent ***ctrls);
 
 /**
- * nvme_scan_ctrl_namespace_paths() -
- * @c:
- * @namespaces:
+ * nvme_scan_ctrl_namespace_paths() - Scan for namespace paths in a controller
+ * @c: Controller to scan
+ * @paths: Pointer to array of dirents
  *
- * Return: 
+ * Return: number of entries in @paths
  */
-int nvme_scan_ctrl_namespace_paths(nvme_ctrl_t c, struct dirent ***namespaces);
+int nvme_scan_ctrl_namespace_paths(nvme_ctrl_t c, struct dirent ***paths);
 
 /**
- * nvme_scan_ctrl_namespaces() -
- * @c:
- * @namespaces:
+ * nvme_scan_ctrl_namespaces() - Scan for namespaces in a controller
+ * @c: Controller to scan
+ * @ns: Pointer to array of dirents
  *
- * Return: 
+ * Return: number of entries in @ns
  */
-int nvme_scan_ctrl_namespaces(nvme_ctrl_t c, struct dirent ***namespaces);
+int nvme_scan_ctrl_namespaces(nvme_ctrl_t c, struct dirent ***ns);
 
 #endif /* _LIBNVME_FILTERS_H */
-- 
2.50.1