From 4f0134d23f9b6388f0eed16b72a701aeee0c861e Mon Sep 17 00:00:00 2001 From: Hadar Hen Zion Date: Mon, 4 Mar 2013 13:54:27 +0200 Subject: [PATCH] mlx4_core: Fix Coverity issues. Signed-off-by: Itai Garbi Signed-off-by: Hadar Hen Zion (Ported from Mellanox OFED 2.4) Signed-off-by: Mukesh Kacker --- drivers/net/ethernet/mellanox/mlx4/cmd.c | 3 +++ drivers/net/ethernet/mellanox/mlx4/eq.c | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellanox/mlx4/cmd.c index 973328bcc191..27ee706ae947 100644 --- a/drivers/net/ethernet/mellanox/mlx4/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c @@ -710,6 +710,9 @@ static int mlx4_cmd_wait(struct mlx4_dev *dev, u64 in_param, u64 *out_param, int go_bit = 0, t_bit = 0, stat_err; u32 status = 0; + if (out_is_imm && !out_param) + return -EINVAL; + down(&cmd->event_sem); spin_lock(&cmd->context_lock); diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c b/drivers/net/ethernet/mellanox/mlx4/eq.c index b4b68d715c32..4e9c01be5fcf 100644 --- a/drivers/net/ethernet/mellanox/mlx4/eq.c +++ b/drivers/net/ethernet/mellanox/mlx4/eq.c @@ -516,6 +516,7 @@ static int mlx4_eq_int(struct mlx4_dev *dev, struct mlx4_eq *eq) case MLX4_EVENT_TYPE_SRQ_LIMIT: mlx4_dbg(dev, "%s: MLX4_EVENT_TYPE_SRQ_LIMIT\n", __func__); + /* fall through */ case MLX4_EVENT_TYPE_SRQ_CATAS_ERROR: if (mlx4_is_master(dev)) { /* forward only to slave owning the SRQ */ -- 2.50.1