From 43fa8905db08a39d4d0a709f6f3294037c4db425 Mon Sep 17 00:00:00 2001 From: Jeff Layton Date: Sun, 9 Feb 2025 07:31:24 -0500 Subject: [PATCH] nfsd: always release slot when requeueing callback If the callback is going to be requeued to the workqueue, then release the slot. The callback client and session could change and the slot may no longer be valid after that point. Signed-off-by: Jeff Layton Signed-off-by: Chuck Lever --- fs/nfsd/nfs4callback.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c index 5eabba4cc6c5..640d788052fd 100644 --- a/fs/nfsd/nfs4callback.c +++ b/fs/nfsd/nfs4callback.c @@ -1405,6 +1405,7 @@ retry_nowait: rpc_restart_call_prepare(task); goto out; requeue: + nfsd41_cb_release_slot(cb); nfsd4_requeue_cb(task, cb); return false; } -- 2.50.1