From 411f45d3d00b20a29098c5763e61cabdb7d86cb4 Mon Sep 17 00:00:00 2001 From: Sowmini Varadhan Date: Wed, 31 May 2017 12:11:20 -0700 Subject: [PATCH] rds: tcp: canonical connection order for all paths with index > 0 The rds_connect_worker() has a bug in the check that enforces the canonical connection order described in the comments of rds_tcp_state_change(). The intention is to make sure that all the multipath connections are always initiated by the smaller IP address via rds_start_mprds. To achieve this, rds_connection_worker should check that cp_index > 0. Orabug: 26241322 (Cherry-pick of upstream 087d975353d0cc9b7536d6ef46cd9303fceb2e17) Signed-off-by: Sowmini Varadhan Acked-by: Santosh Shilimkar Signed-off-by: David S. Miller --- net/rds/threads.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rds/threads.c b/net/rds/threads.c index e4ea0c4f7440..1e0ea785e4db 100644 --- a/net/rds/threads.c +++ b/net/rds/threads.c @@ -177,7 +177,7 @@ void rds_connect_worker(struct work_struct *work) int ret; bool is_tcp = conn->c_trans->t_type == RDS_TRANS_TCP; - if (is_tcp && cp->cp_index > 1 && + if (is_tcp && cp->cp_index > 0 && cp->cp_conn->c_laddr > cp->cp_conn->c_faddr) return; clear_bit(RDS_RECONNECT_PENDING, &cp->cp_flags); -- 2.50.1