From 3a7925c103bed713d795347adf6849533c6076b1 Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Wed, 5 Dec 2018 11:13:56 +1100 Subject: [PATCH] mm-mmu_notifier-use-structure-for-invalidate_range_start-end-calls-checkpatch-fixes ERROR: code indent should use tabs where possible #102: FILE: include/linux/mm.h:1506: +^I^I ^I struct mmu_notifier_range *range,$ WARNING: please, no space before tabs #102: FILE: include/linux/mm.h:1506: +^I^I ^I struct mmu_notifier_range *range,$ WARNING: function definition argument 'struct mmu_notifier_range *' should also have an identifier name #117: FILE: include/linux/mmu_notifier.h:223: +extern int __mmu_notifier_invalidate_range_start(struct mmu_notifier_range *); ERROR: code indent should use tabs where possible #922: FILE: mm/memory.c:4122: +^I^I ^I struct mmu_notifier_range *range,$ WARNING: please, no space before tabs #922: FILE: mm/memory.c:4122: +^I^I ^I struct mmu_notifier_range *range,$ WARNING: line over 80 characters #1033: FILE: mm/mmu_notifier.c:183: + !range->blockable ? "non-" : ""); WARNING: line over 80 characters #1170: FILE: mm/oom_kill.c:539: + if (mmu_notifier_invalidate_range_start_nonblock(&range)) { WARNING: line over 80 characters #1178: FILE: mm/oom_kill.c:544: + unmap_page_range(&tlb, vma, range.start, range.end, NULL); total: 2 errors, 6 warnings, 1133 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile ./patches/mm-mmu_notifier-use-structure-for-invalidate_range_start-end-calls.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Jerome Glisse Signed-off-by: Andrew Morton Signed-off-by: Stephen Rothwell --- include/linux/mm.h | 4 ++-- include/linux/mmu_notifier.h | 2 +- mm/memory.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 7c43af33c029..d5ce375d6fb8 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1461,8 +1461,8 @@ void free_pgd_range(struct mmu_gather *tlb, unsigned long addr, int copy_page_range(struct mm_struct *dst, struct mm_struct *src, struct vm_area_struct *vma); int follow_pte_pmd(struct mm_struct *mm, unsigned long address, - struct mmu_notifier_range *range, - pte_t **ptepp, pmd_t **pmdpp, spinlock_t **ptlp); + struct mmu_notifier_range *range, + pte_t **ptepp, pmd_t **pmdpp, spinlock_t **ptlp); int follow_pfn(struct vm_area_struct *vma, unsigned long address, unsigned long *pfn); int follow_phys(struct vm_area_struct *vma, unsigned long address, diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h index 0fee0c577025..a85b845ec99b 100644 --- a/include/linux/mmu_notifier.h +++ b/include/linux/mmu_notifier.h @@ -220,7 +220,7 @@ extern int __mmu_notifier_test_young(struct mm_struct *mm, unsigned long address); extern void __mmu_notifier_change_pte(struct mm_struct *mm, unsigned long address, pte_t pte); -extern int __mmu_notifier_invalidate_range_start(struct mmu_notifier_range *); +extern int __mmu_notifier_invalidate_range_start(struct mmu_notifier_range *r); extern void __mmu_notifier_invalidate_range_end(struct mmu_notifier_range *r, bool only_end); extern void __mmu_notifier_invalidate_range(struct mm_struct *mm, diff --git a/mm/memory.c b/mm/memory.c index 607224eb4d7f..cdc0c3840e29 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -4119,8 +4119,8 @@ static inline int follow_pte(struct mm_struct *mm, unsigned long address, } int follow_pte_pmd(struct mm_struct *mm, unsigned long address, - struct mmu_notifier_range *range, - pte_t **ptepp, pmd_t **pmdpp, spinlock_t **ptlp) + struct mmu_notifier_range *range, + pte_t **ptepp, pmd_t **pmdpp, spinlock_t **ptlp) { int res; -- 2.50.1