From 38abdcbd86801cc251b61ba15d59175679a80107 Mon Sep 17 00:00:00 2001 From: "Darrick J. Wong" Date: Thu, 27 Feb 2020 15:49:27 -0500 Subject: [PATCH] xfs_scrub: fix reporting of EINVAL for online repairs The arguments to str_corrupt() are in the wrong order. Fix that. Fixes: de5d20ece73f579 ("libfrog: convert scrub.c functions to negative error codes") Signed-off-by: Darrick J. Wong Reviewed-by: Eric Sandeen Signed-off-by: Eric Sandeen --- scrub/scrub.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/scrub/scrub.c b/scrub/scrub.c index 2885aa34e..81a9ca858 100644 --- a/scrub/scrub.c +++ b/scrub/scrub.c @@ -744,9 +744,8 @@ _("Filesystem is shut down, aborting.")); /* fall through */ case EINVAL: /* Kernel doesn't know how to repair this? */ - str_corrupt(ctx, -_("%s: Don't know how to fix; offline repair required."), - descr_render(&dsc)); + str_corrupt(ctx, descr_render(&dsc), +_("Don't know how to fix; offline repair required.")); return CHECK_DONE; case EROFS: /* Read-only filesystem, can't fix. */ -- 2.49.0