From 33cd93435cea665b24ca3f9b3d6af42afb3ba7bc Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Thu, 8 May 2025 09:26:25 +0300 Subject: [PATCH] crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf_probe() The pcim_iomap_region() returns error pointers. It doesn't return NULL pointers. Update the check to match. Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver") Signed-off-by: Dan Carpenter Acked-by: Giovanni Cabiddu Signed-off-by: Herbert Xu --- drivers/crypto/intel/qat/qat_6xxx/adf_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c b/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c index 2531c337e0dd..132e26501621 100644 --- a/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c +++ b/drivers/crypto/intel/qat/qat_6xxx/adf_drv.c @@ -156,8 +156,8 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent) /* Map 64-bit PCIe BAR */ bar->virt_addr = pcim_iomap_region(pdev, bar_map[i], pci_name(pdev)); - if (!bar->virt_addr) { - ret = -ENOMEM; + if (IS_ERR(bar->virt_addr)) { + ret = PTR_ERR(bar->virt_addr); return dev_err_probe(dev, ret, "Failed to ioremap PCI region.\n"); } } -- 2.50.1