From 28f8c4c7fbfda4aa321185cab0cbbca19cbe6954 Mon Sep 17 00:00:00 2001 From: Jeff Moyer Date: Wed, 18 Jun 2014 09:29:57 +1000 Subject: [PATCH] resvtest.c: fix invalid use of sizeof() sizeof(pointer) will give you the size of a pointer, not the space allocated to it. I noticed this when gcc complained: resvtest.c:76:33: warning: argument to 'sizeof' in 'memset' call is the same expression as the destination; did you mean to provide an explicit length? [-Wsizeof-pointer-memaccess] memset(writebuffer, 'A', sizeof(writebuffer)); Signed-off-by: Jeff Moyer Reviewed-by: Alex Elder Signed-off-by: Dave Chinner --- src/resvtest.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/resvtest.c b/src/resvtest.c index 037d9ea93..ecad03178 100644 --- a/src/resvtest.c +++ b/src/resvtest.c @@ -73,7 +73,7 @@ main(int argc, char **argv) perror("open"); exit(1); } - memset(writebuffer, 'A', sizeof(writebuffer)); + memset(writebuffer, 'A', bsize); unlink(filename); writefd = open(filename, O_RDWR | O_CREAT | O_EXCL, S_IRUSR | S_IWUSR); @@ -111,7 +111,7 @@ main(int argc, char **argv) char *p; int numerrors; - if (write(writefd, writebuffer, sizeof(writebuffer)) < 0) { + if (write(writefd, writebuffer, bsize) < 0) { perror("write"); exit(1); } @@ -128,11 +128,11 @@ main(int argc, char **argv) lseek(readfd, SEEK_SET, 0); numerrors = 0; for (j = 0; j < n; j++) { - if (read(readfd, readbuffer, sizeof(readbuffer)) < 0) { + if (read(readfd, readbuffer, bsize) < 0) { perror("read"); exit(1); } - for (i = 0; i < sizeof(readbuffer); i++) { + for (i = 0; i < bsize; i++) { if (readbuffer[i] != 'A') { fprintf(stderr, "errors detected in file, pos: %d (%lld+%d), nwrites: %d [val=0x%x].\n", -- 2.51.0