From 2528dfee694679e7759801df17a9291b72e1c351 Mon Sep 17 00:00:00 2001 From: Michael Chan Date: Fri, 1 Jul 2016 18:46:19 -0400 Subject: [PATCH] bnxt_en: VF/NPAR should return -EOPNOTSUPP for unsupported ethtool ops. Orabug: 24567991 Returning 0 for doing nothing is confusing to the user. Signed-off-by: Michael Chan Signed-off-by: David S. Miller (cherry picked from commit 75362a3fd4e37ff8af1ef5e3d9f2d9d5ccf2f3ab) Signed-off-by: Brian Maly Signed-off-by: Dhaval Giani --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index 730e761fe154..a59dceedcb2f 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c @@ -1182,7 +1182,7 @@ static int bnxt_set_pauseparam(struct net_device *dev, struct bnxt_link_info *link_info = &bp->link_info; if (!BNXT_SINGLE_PF(bp)) - return rc; + return -EOPNOTSUPP; if (epause->autoneg) { if (!(link_info->autoneg & BNXT_AUTONEG_SPEED)) @@ -1704,7 +1704,7 @@ static int bnxt_set_eee(struct net_device *dev, struct ethtool_eee *edata) int rc = 0; if (!BNXT_SINGLE_PF(bp)) - return 0; + return -EOPNOTSUPP; if (!(bp->flags & BNXT_FLAG_EEE_CAP)) return -EOPNOTSUPP; -- 2.50.1