From 235be65750d7c6ed76e2f82bc1fdbfd07a76b19d Mon Sep 17 00:00:00 2001 From: Gollu Appalanaidu Date: Tue, 2 Feb 2021 22:36:25 +0530 Subject: [PATCH] nvme: fix log-id data type and remove unnecessary log-id validtion Signed-off-by: Gollu Appalanaidu --- nvme.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/nvme.c b/nvme.c index 5a11d70e..f6de23a0 100644 --- a/nvme.c +++ b/nvme.c @@ -1024,7 +1024,7 @@ static int get_log(int argc, char **argv, struct command *cmd, struct plugin *pl struct config { __u32 namespace_id; - __u32 log_id; + __u8 log_id; __u32 log_len; __u32 aen; __u64 lpo; @@ -1036,7 +1036,7 @@ static int get_log(int argc, char **argv, struct command *cmd, struct plugin *pl struct config cfg = { .namespace_id = NVME_NSID_ALL, - .log_id = 0xffffffff, + .log_id = 0xff, .log_len = 0, .lpo = NVME_NO_LOG_LPO, .lsp = NVME_NO_LOG_LSP, @@ -1066,12 +1066,6 @@ static int get_log(int argc, char **argv, struct command *cmd, struct plugin *pl cfg.log_id = (cfg.aen >> 16) & 0xff; } - if (cfg.log_id > 0xff) { - fprintf(stderr, "Invalid log identifier: %d. Valid range: 0-255\n", cfg.log_id); - err = -EINVAL; - goto close_fd; - } - if (!cfg.log_len) { fprintf(stderr, "non-zero log-len is required param\n"); err = -EINVAL; -- 2.50.1