From 1851c0f29d8a75ceeb1de1ac1379196a1f2aabaf Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Wed, 16 Apr 2025 14:09:33 +0300 Subject: [PATCH] iio: dac: ad5592r: Delete stray unlock in ad5592r_write_raw() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This code was converted to use guard locks but one of the unlocks was accidentally overlooked. Delete it. Fixes: 135e101f4dd6 ("iio: dac: ad5592r: use lock guards") Signed-off-by: Dan Carpenter Reviewed-by: Andy Shevchenko Reviewed-by: Nuno Sá Reviewed-by: Bartosz Golaszewski Link: https://patch.msgid.link/Z_-P7bsD3KL5K25R@stanley.mountain Signed-off-by: Jonathan Cameron --- drivers/iio/dac/ad5592r-base.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c index 217a8a88818d..5f2cd51723f6 100644 --- a/drivers/iio/dac/ad5592r-base.c +++ b/drivers/iio/dac/ad5592r-base.c @@ -324,10 +324,8 @@ static int ad5592r_write_raw(struct iio_dev *iio_dev, ret = st->ops->reg_read(st, AD5592R_REG_CTRL, &st->cached_gp_ctrl); - if (ret < 0) { - mutex_unlock(&st->lock); + if (ret < 0) return ret; - } if (chan->output) { if (gain) -- 2.51.0