From 18135881a9cd87b5b01e17b65143d3592044905f Mon Sep 17 00:00:00 2001 From: Pradeep Gopanapalli Date: Fri, 6 Nov 2015 18:11:33 -0800 Subject: [PATCH] 1) S_IRWXU causing kernel soft crash changing to 0644 WARNING: CPU: 0 PID: 20907 at fs/sysfs/group.c:61 create_files+0x171/0x180() Oct 12 21:43:14 ovn87-180 kernel: [252606.588541] Attribute vhba_default_scsi_timeout: Invalid permissions 0700 [Rev 8008] Reviewed-by: Sajid Zia Signed-off-by: Pradeep Gopanapalli Signed-off-by: Qing Huang --- drivers/infiniband/ulp/xsigo/xsvhba/Makefile | 2 +- drivers/infiniband/ulp/xsigo/xsvhba/vhba_main.c | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/infiniband/ulp/xsigo/xsvhba/Makefile b/drivers/infiniband/ulp/xsigo/xsvhba/Makefile index bf12208b9381..6ea65b0ad0bf 100644 --- a/drivers/infiniband/ulp/xsigo/xsvhba/Makefile +++ b/drivers/infiniband/ulp/xsigo/xsvhba/Makefile @@ -3,7 +3,7 @@ xsvhba-y := vhba_main.o vhba_xsmp.o vhba_create.o vhba_init.o vhba_delete.o \ vhba_attr.o vhba_wq.o vhba_proc.o vhba_stats.o vhba_ib.o \ vhba_scsi_intf.o vhba_align.o -ccflags-y += -DXSIGO_LOCAL_VERSION=\"6.0.r8004\" +ccflags-y += -DXSIGO_LOCAL_VERSION=\"6.0.r8008\" ccflags-y += -DRDMA_PORT_LINK_LAYER_CHANGES -DHAS_SKB_ACCESS_FUNCTIONS ccflags-y += -DSCSI_STRUCT_CHANGES -DSCSI_TIMEOUT_CHANGES -DLLE ccflags-y += -DXG_FRAG_SIZE_PRESENT -DXG_FRAG_PAGE_PRESENT diff --git a/drivers/infiniband/ulp/xsigo/xsvhba/vhba_main.c b/drivers/infiniband/ulp/xsigo/xsvhba/vhba_main.c index 0a112bd77f14..1784899ce371 100644 --- a/drivers/infiniband/ulp/xsigo/xsvhba/vhba_main.c +++ b/drivers/infiniband/ulp/xsigo/xsvhba/vhba_main.c @@ -71,25 +71,25 @@ MODULE_VERSION(DRIVER_VERSION); ***********************************/ int cmds_per_lun = 16; -module_param(cmds_per_lun, int, S_IRWXU); +module_param(cmds_per_lun, int, 0644); int vhba_multiple_q = 1; -module_param(vhba_multiple_q, int, S_IRWXU); +module_param(vhba_multiple_q, int, 0644); int vhba_max_transfer_size = VHBA_DEFAULT_TRANSFER_SIZE; -module_param(vhba_max_transfer_size, int, S_IRWXU); +module_param(vhba_max_transfer_size, int, 0644); int vhba_max_q_depth = VHBA_MAX_VH_Q_DEPTH; -module_param(vhba_max_q_depth, int, S_IRWXU); +module_param(vhba_max_q_depth, int, 0644); int vhba_debug = 0x200001; module_param(vhba_debug, int, 0644); int vhba_max_scsi_retry = VHBA_MAX_SCSI_RETRY; -module_param(vhba_max_scsi_retry, int, S_IRWXU); +module_param(vhba_max_scsi_retry, int, 0644); int vhba_default_scsi_timeout = VHBA_DEFAULT_SCSI_TIMEOUT; -module_param(vhba_default_scsi_timeout, int, S_IRWXU); +module_param(vhba_default_scsi_timeout, int, 0644); int vhba_wait_in_boot = 1; module_param(vhba_wait_in_boot, int, 0644); -- 2.50.1