From 162c461d6d7fdba91b3ce04183b7f9ac985668ca Mon Sep 17 00:00:00 2001 From: Nick Alcock Date: Wed, 3 Oct 2012 19:31:10 +0100 Subject: [PATCH] ctf: Note a future enhancement In -DDEBUG mode, we should not assume that identically-named structures with different numbers of members are declarations of the same structure with a shared prefix, but should validate it. (The compiler cannot always verify this, e.g. if the same structure is defined in multiple translation units.) Signed-off-by: Nick Alcock --- scripts/dwarf2ctf/dwarf2ctf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/dwarf2ctf/dwarf2ctf.c b/scripts/dwarf2ctf/dwarf2ctf.c index 37c4f8197301..4a6d445301cf 100644 --- a/scripts/dwarf2ctf/dwarf2ctf.c +++ b/scripts/dwarf2ctf/dwarf2ctf.c @@ -2774,6 +2774,8 @@ static ctf_id_t assemble_ctf_cvr_qual(const char *module_name, * We assume that if a structure or union type is discovered with more members * than an earlier-discovered type, that it is compatible with that earlier type * and a superset of it. + * + * FIXME: in debug mode we should not assume this. */ static ctf_id_t assemble_ctf_struct_union(const char *module_name, const char *file_name, -- 2.50.1