From 14d09354cddd5c217d7293f414924b0b8b89bcc5 Mon Sep 17 00:00:00 2001 From: Minsik Jeon Date: Wed, 21 Aug 2024 19:22:01 +0900 Subject: [PATCH] plugins/fdp: bugfix error check to validate output format The return value of validate_output_format functions is whether the functions fails. So I fix to check the err variable. Signed-off-by: Minsik Jeon --- plugins/fdp/fdp.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/plugins/fdp/fdp.c b/plugins/fdp/fdp.c index 1efdd76d..cac0b2bd 100644 --- a/plugins/fdp/fdp.c +++ b/plugins/fdp/fdp.c @@ -57,7 +57,7 @@ static int fdp_configs(int argc, char **argv, struct command *cmd, return err; err = validate_output_format(cfg.output_format, &flags); - if (flags < 0) + if (err < 0) goto out; if (cfg.raw_binary) @@ -138,7 +138,7 @@ static int fdp_usage(int argc, char **argv, struct command *cmd, struct plugin * return err; err = validate_output_format(cfg.output_format, &flags); - if (flags < 0) + if (err < 0) goto out; if (cfg.raw_binary) @@ -209,7 +209,7 @@ static int fdp_stats(int argc, char **argv, struct command *cmd, struct plugin * return err; err = validate_output_format(cfg.output_format, &flags); - if (flags < 0) + if (err < 0) goto out; if (cfg.raw_binary) @@ -270,7 +270,7 @@ static int fdp_events(int argc, char **argv, struct command *cmd, struct plugin return err; err = validate_output_format(cfg.output_format, &flags); - if (flags < 0) + if (err < 0) goto out; if (cfg.raw_binary) @@ -329,7 +329,7 @@ static int fdp_status(int argc, char **argv, struct command *cmd, struct plugin return err; err = validate_output_format(cfg.output_format, &flags); - if (flags < 0) + if (err < 0) goto out; if (cfg.raw_binary) -- 2.51.0