From 13e0a6897e6943091040ea27601b31b540367b8e Mon Sep 17 00:00:00 2001 From: Pavel Emelyanov Date: Tue, 15 Jul 2014 09:23:01 +0800 Subject: [PATCH] rds: Lost locking in loop connection freeing upstream commit: 58c490babd4b425310363cbd1f406d7e508f77a5 rds: Lost locking in loop connection freeing The conn is removed from list in there and this requires proper lock protection. Orabug: 19265200 Signed-off-by: Pavel Emelyanov Signed-off-by: David S. Miller Signed-off-by: Wengang Wang Signed-off-by: Guangyu Sun (cherry picked from commit 92ad60f3efabfcd9eb40e983a131c730829c0d90) --- net/rds/loop.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/rds/loop.c b/net/rds/loop.c index c4c03a02a5b94..e0eac736d8b36 100644 --- a/net/rds/loop.c +++ b/net/rds/loop.c @@ -133,8 +133,12 @@ static int rds_loop_conn_alloc(struct rds_connection *conn, gfp_t gfp) static void rds_loop_conn_free(void *arg) { struct rds_loop_connection *lc = arg; + unsigned long flags; + rdsdebug("lc %p\n", lc); + spin_lock_irqsave(&loop_conns_lock, flags); list_del(&lc->loop_node); + spin_unlock_irqrestore(&loop_conns_lock, flags); kfree(lc); } -- 2.50.1