From 132263220ddacaa5d4a93c34675eb9639dcc3707 Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Fri, 30 May 2025 19:09:11 -0400 Subject: [PATCH] bcachefs: Add better logging to fsck_rename_dirent() Signed-off-by: Kent Overstreet --- fs/bcachefs/str_hash.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/fs/bcachefs/str_hash.c b/fs/bcachefs/str_hash.c index f101ca8581d9..7b97852d1cdf 100644 --- a/fs/bcachefs/str_hash.c +++ b/fs/bcachefs/str_hash.c @@ -61,14 +61,19 @@ static noinline int fsck_rename_dirent(struct btree_trans *trans, (subvol_inum) { 0, old.k->p.inode }, old.k->p.snapshot, &new->k_i, BTREE_UPDATE_internal_snapshot_node); - if (!bch2_err_matches(ret, EEXIST)) + if (ret && !bch2_err_matches(ret, EEXIST)) + goto err; + if (!ret) break; } if (ret) - return ret; + goto err; - return bch2_fsck_update_backpointers(trans, s, desc, hash_info, &new->k_i); + ret = bch2_fsck_update_backpointers(trans, s, desc, hash_info, &new->k_i); +err: + bch_err_fn(trans->c, ret); + return ret; } static noinline int hash_pick_winner(struct btree_trans *trans, -- 2.50.1