From 03861fe86a3d11dea885be98a2530648558fb968 Mon Sep 17 00:00:00 2001 From: Eric Dumazet Date: Sun, 24 Jan 2016 13:53:50 -0800 Subject: [PATCH] af_unix: fix struct pid memory leak Orabug: 23330931 [ Upstream commit fa0dc04df259ba2df3ce1920e9690c7842f8fa4b ] Dmitry reported a struct pid leak detected by a syzkaller program. Bug happens in unix_stream_recvmsg() when we break the loop when a signal is pending, without properly releasing scm. Fixes: b3ca9b02b007 ("net: fix multithreaded signal handling in unix recv routines") Reported-by: Dmitry Vyukov Signed-off-by: Eric Dumazet Cc: Rainer Weikusat Signed-off-by: David S. Miller Signed-off-by: Sasha Levin (cherry picked from commit 8d988538da0c17711c0de0a53fc38cef49e3ed1b) Signed-off-by: Dan Duval --- net/unix/af_unix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 05dbffdea76f..bed68be19197 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -2139,6 +2139,7 @@ again: if (signal_pending(current) || mutex_lock_interruptible(&u->readlock)) { err = sock_intr_errno(timeo); + scm_destroy(&scm); goto out; } -- 2.50.1